Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTD-5407 create management command and added tests #2185

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Tllew
Copy link
Contributor

@Tllew Tllew commented Sep 16, 2024

Aim

LTD-

Copy link
Contributor

@depsiatwal depsiatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@depsiatwal
Copy link
Contributor

Based as this is fixed now I would wait for this
#2183

audit_trail_service.create(
actor=system_user,
verb=AuditType.DEVELOPER_INTERVENTION,
target=party,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change to the case rather then party so it's displayed in the case N&T

Copy link
Contributor

@markj0hnst0n markj0hnst0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Gurdeep's comment about adding to case but happy to approve based on that change

@Tllew Tllew merged commit aa4338c into dev Sep 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants