Prod Release #2186
Merged
Prod Release #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
The users created using this command are by default belong to Admin team and queue is set to 'All cases'. This is a problem in E2E tests as when we sign in as different users their team and queue are not correct. Because of this we are having to switch team, queue as part of the test and as these persist between tests it can cause test failures. Better approach is to seed certain users with expected roles, teams, queues etc.
Ltd 5383 Good name and Party address validator
This stops a race condition where an amendment request hits our API multiple times simultaneously
add comment back in remove gov notifications removing a bit more add system queue counts back in test update remove commented out code and add back in code which sends notification to other exporters remove unused variable update application_helpers to remove notification update tests remove updated queue tests add comment back in
…on-fix Fix a race condition when multiple amendments are made
…pened-case LTD-5355 remove GovNotification
Update seedinternalusers command to accept team and default queue
UAT release
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
| @@ -1,3 +1,4 @@ | |||
| import logging | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim
LTD-