Ltd 5378 licence list bug #2192
Conversation
kevincarrogan
force-pushed
the
LTD-5378-licence-list-bug
branch
2 times, most recently
from
ef4e630
to
58dbf71
Compare
| control_list_entries = ControlListEntrySerializer(source="good.good.control_list_entries", many=True) | ||
| assessed_control_list_entries = ControlListEntrySerializer(source="good.control_list_entries", many=True) |
There was a problem hiding this comment.
Is this to future proof where these can be different in future?
There was a problem hiding this comment.
I actually think that it's wrong that we're displaying good.good.control_list_entries on the licence page now so I want to change that but I wanted to do this in a backward compatible way by adding this new field first.
There was a problem hiding this comment.
I'm also adding name to the serializer, which wasn't there before, as that field is now mostly blank so I also want to change the frontend to use name.
kevincarrogan
force-pushed
the
LTD-5378-licence-list-bug
branch
2 times, most recently
from
dd765d4
to
c7b8811
Compare
Not yet. I want to deploy this first and then I can update the frontend. |
kevincarrogan
force-pushed
the
LTD-5378-licence-list-bug
branch
from
c7b8811
to
de7c109
Compare
But we've checked it's backward compatible I mean ? |
Yes. It's backwards compatible. |
kevincarrogan
force-pushed
the
LTD-5378-licence-list-bug
branch
from
de7c109
to
2324b5b
Compare
Aim
Fix licence list page when a good has been used multiple times on an application.
The issue was around advice objects being generated multiple times for the same good and one of the serializers falling over as a result.
The serializer for this page actually didn't need to load the advice at all so I've created a separate serializer that just sends what's required for the licence list page.
I've also separated out the Data Workspace serializer as well as this was also loading up information that it didn't need to.
LTD-5378