perf: faster ZipCrypto decompression #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalc
force-pushed
the
perf/faster-password-decrypt
branch
from
0140820 to
612435f
Compare
michalc
force-pushed
the
perf/faster-password-decrypt
branch
from
612435f to
176e274
Compare
Inspired by the report at #91, found some performance improvements for the ZipCrypto function, decrypt_weak_decompress. From some light testing of a password proteceted 100MB file of pseudo-random data on my local filesystem, it seems to reduce decryption+decompression time from ~55 seconds to ~45 seconds, which also makes it a bit faster than Python's zipfile, at least in this circumstance.
michalc
force-pushed
the
perf/faster-password-decrypt
branch
from
176e274 to
7075b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the report at #91, found some performance improvements for the ZipCrypto function, decrypt_weak_decompress. From some light testing of a password proteceted 100MB file of pseudo-random data on my local filesystem, it seems to reduce decryption+decompression time from ~55 seconds to ~45 seconds, which also makes it a bit faster than Python's zipfile, at least in this circumstance.