build(deps): move to govuk-eleventy-plugin v6.0.3 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves to the govuk-eleventy-plugin for documentation to the current latest, v6.0.3 There are a few breaking changes, documented at https://x-govuk.github.io/govuk-eleventy-plugin/upgrading/5-to-6/. The trikiest of these is the change of how the organisation name is now inside the SVG logo. This required a few iterations of: - Editing the logo with Inkscape - Manually editing the SVG / associated CSS - Using an SVG minifier to reduce its size The logo is now a bit smaller in size than it was even though it also has the "DBT" text in it, but from what I can tell looking at it, no loss of quality. So a small step forward on that front even ignoring the version bump. I did spend some time trying to put the organisation name in as HTML text in the page, but it required too much faff with CSS to get it looking right. It's essentially fighting the latest version of GOV.UK frontend which expects it to be part of the logo.
michalc
added a commit
to uktrade/stream-unzip
that referenced
this pull request
Jan 9, 2024
This is a straight copy of similar changes in stream-zip: uktrade/stream-zip#103 uktrade/stream-zip#104
michalc
added a commit
to uktrade/stream-unzip
that referenced
this pull request
Jan 9, 2024
This is a straight copy of similar changes in stream-zip: uktrade/stream-zip#103 uktrade/stream-zip#104
michalc
added a commit
to uktrade/pg-bulk-ingest
that referenced
this pull request
Jan 9, 2024
This is a straight copy of similar changes in stream-zip: uktrade/stream-zip#103 uktrade/stream-zip#104
michalc
added a commit
to uktrade/pg-bulk-ingest
that referenced
this pull request
Jan 9, 2024
This is a straight copy of similar changes in stream-zip: uktrade/stream-zip#103 uktrade/stream-zip#104
michalc
added a commit
to uktrade/stream-read-xbrl
that referenced
this pull request
Jan 9, 2024
This is a straight copy of similar changes in stream-zip: uktrade/stream-zip#103 uktrade/stream-zip#104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves to the govuk-eleventy-plugin for documentation to the current latest, v6.0.3
There are a few breaking changes, documented at
https://x-govuk.github.io/govuk-eleventy-plugin/upgrading/5-to-6/. The trikiest of these is the change of how the organisation name is now inside the SVG logo. This required a few iterations of:
The logo is now a bit smaller in size than it was even though it also has the "DBT" text in it, but from what I can tell looking at it, no loss of quality. So a small step forward on that front even ignoring the version bump.
I did spend some time trying to put the organisation name in as HTML text in the page, but it required too much faff with CSS to get it looking right. It's essentially fighting the latest version of GOV.UK frontend which expects it to be part of the logo.