ci: release process now includes a file with the source, but modified with correct version #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalc
force-pushed
the
ci/release-to-include-version
branch
2 times, most recently
from
9296607 to
f2f7aa0
Compare
Mostly just since I noticed it was out of date, but also I think it does some interactions with tokens and things, and makes it easier to use to use the GitHub CLI in later step. Not sure if the earlier version does that, but we'll need to bump at some point, so may as well be now.
michalc
force-pushed
the
ci/release-to-include-version
branch
from
f2f7aa0 to
b548587
Compare
The source does not actually include the correct release version to avoid having to change the source code based on the current or next version. While this is maybe odd, it makes releasing quite easy. However, as #136 this makes it slightly harder to release for Debian. So we make a version of the source code that has the correct release version, and add it to the GitHub release. This makes it so any tinkering with versions is just done in this repository.
michalc
force-pushed
the
ci/release-to-include-version
branch
from
10ce1bb to
1d85aca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source does not actually include the correct release version to avoid having to change the source code based on the current or next version. While this is maybe odd, it makes releasing quite easy. However, as #136 this makes it slightly harder to release for Debian.
So we make a version of the source code that has the correct release version, and add it to the GitHub release. This makes it so any tinkering with versions is just done in this repository.
Bumping the checkout version just by the by