fix: really attempt to return _all_ bytes if plain read called #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behaviour limits a single read to 2^63 - 1 bytes, even if all are requested. However, this is wrong. If all are requested all should be returned. There is a (strong!) possibility that more bytes than 2^63 - 1 cannot be allocated. But then this is a reason that the function should error - it should not behave as though 2^63 - 1 bytes is the entire stream. This is probably all academic... I suspect there isn't a system around running Python that could come close to allocating 2^63 - 1 bytes.
michalc
force-pushed
the
fix/really-return-all-if-no-size
branch
from
c395c18 to
65c8f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behaviour limits a single read to 2^63 - 1 bytes, even if all are requested. However, this is wrong. If all are requested all should be returned.
There is a (strong!) possibility that more bytes than 2^63 - 1 cannot be allocated. But then this is a reason that the function should error - it should not behave as though 2^63 - 1 bytes is the entire stream.
This is probably all academic... I suspect there isn't a system around running Python that could come close to allocating 2^63 - 1 bytes.