Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to install windows-curses in MSYS2 #78

Closed
wants to merge 1 commit into from

Conversation

dobairoland
Copy link

@ulfalizer Please take a look. I believe that this solves the problem.

Closes #77

@ulfalizer
Copy link
Owner

Won't work when Kconfiglib is installed as a Python wheel, unfortunately. Wheels are the usual case nowadays, e.g. when using pip.

setup.py only gets run when building the wheel, not at installation time.

Thinking I should just drop the windows-curses dependency, bump the major version, add a warning somewhere, and hope it doesn't cause too many problems. Would be nice if there was some hacky way to detect MSYS2 with the Wheel format though.

@ulfalizer
Copy link
Owner

Fixed a different way with 068bc48.

@ulfalizer ulfalizer closed this Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kconfiglib cannot be installed from MSYS
2 participants