Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore github URLs in broken link checks #258

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Oct 23, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved the URL validation process to better handle GitHub links in the utilities of the Ultralytics Actions.

πŸ“Š Key Changes

  • Updated the URL validation function in common_utils.py to ignore GitHub links, treating them similarly to private repositories.

🎯 Purpose & Impact

  • Enhanced Reliability: By ignoring GitHub URLs, this change reduces unnecessary validation errors and retries, especially useful for handling private repositories. πŸš€
  • User Convenience: Streamlines processes involving GitHub URLs, potentially improving workflow efficiency for users handling multiple repository links. 🌐

@UltralyticsAssistant UltralyticsAssistant added the enhancement New feature or request label Oct 23, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/actions πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/actions main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

For more guidance, please refer to our Contributing Guide. If you have any questions, feel free to leave a comment. Thank you for improving the URL validation efficiency in our repository! 🌟

Please note that this is an automated response. An Ultralytics engineer will be available to assist you soon. πŸš€

@glenn-jocher glenn-jocher merged commit 6033538 into main Oct 23, 2024
3 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch October 23, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants