Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publish.yml #69

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Update publish.yml #69

merged 2 commits into from
Oct 29, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Oct 29, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved Slack notifications for GitHub Actions in the Ultralytics/thop repository.

πŸ“Š Key Changes

  • Updated the Slack notification message format in the GitHub workflow to use the current_tag instead of version when a new pip package is published.

🎯 Purpose & Impact

  • Enhanced Clarity: Switching from version to current_tag clarifies exactly which tag of the package has been published, ensuring more precise communication in Slack notifications. πŸ“’
  • Improved Workflow Tracking: Helps team members quickly identify the specific release or update that was successful, improving the efficiency and clarity of development communication. πŸš€

@UltralyticsAssistant UltralyticsAssistant added the devops GitHub Devops or MLops label Oct 29, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/thop πŸš€ PR! This is an automated response to guide you through the process. An Ultralytics engineer will review your PR soon. In the meantime, please review the following checklist to ensure a smooth integration:

  • βœ… Define a Purpose: Clearly explain the purpose of your update in your PR description, and reference any relevant issues. It's crucial for your commit messages to be clear, concise, and consistent with the project's conventions.
  • βœ… Synchronize with Source: Ensure your PR is up-to-date with the ultralytics/thop main branch. If your branch needs updating, click 'Update branch' or use git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Please verify all Ultralytics Continuous Integration (CI) checks pass. If any checks fail, address the issues accordingly.
  • βœ… Update Documentation: If necessary, update the relevant documentation for new or modified features.
  • βœ… Add Tests: Include or update tests if applicable to cover your changes, and ensure all tests are passing.
  • βœ… Sign the CLA: Make sure to sign our Contributor License Agreement if it's your first time contributing to Ultralytics. Confirm by commenting, "I have read the CLA Document and I sign the CLA".
  • βœ… Minimize Changes: Aim to keep changes to the minimum needed for clarity and functionality. As Bruce Lee wisely said, "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is."

For additional guidance, please refer to our Contributing Guide. Feel free to leave a comment if you have any questions. Thank you for helping improve Ultralytics! πŸš€πŸ™

@glenn-jocher glenn-jocher merged commit 21c94bf into main Oct 29, 2024
2 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch October 29, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants