-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimised Callback Class to Reduce Code and Fix Errors #4688
Merged
glenn-jocher
merged 9 commits into
ultralytics:master
from
kalenmike:feature/optimise-callbacks
Sep 7, 2021
Merged
Optimised Callback Class to Reduce Code and Fix Errors #4688
glenn-jocher
merged 9 commits into
ultralytics:master
from
kalenmike:feature/optimise-callbacks
Sep 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made required changes to prevent crash when running from console. |
glenn-jocher
approved these changes
Sep 7, 2021
@kalenmike PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
jveitchmichaelis
added a commit
to jveitchmichaelis/yolov5
that referenced
this pull request
Sep 10, 2021
Fix following ultralytics#4688 which modified the function signature to `train`
glenn-jocher
added a commit
that referenced
this pull request
Sep 10, 2021
CesarBazanAV
pushed a commit
to CesarBazanAV/yolov5
that referenced
this pull request
Sep 29, 2021
* add callbacks to train function in wandb sweep Fix following ultralytics#4688 which modified the function signature to `train` * Cleanup Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Merged
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
* add callbacks to train function in wandb sweep Fix following ultralytics#4688 which modified the function signature to `train` * Cleanup Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
SecretStar112
added a commit
to SecretStar112/yolov5
that referenced
this pull request
May 24, 2023
* add callbacks to train function in wandb sweep Fix following ultralytics/yolov5#4688 which modified the function signature to `train` * Cleanup Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed methods for each callback and implemented checks for available callbacks based on the dictionary defined in the class. Modified train.py to pass the name of the callback hook it is requesting. Initially, this was to fix the callbacks class because some of the methods were not accepting self and this was crashing certain callbacks. To prevent similar mistakes in the future I thought it would be better to combine all the methods into one as they were all using the same code.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improved callback system for greater flexibility in YOLOv5 training and validation flow.
📊 Key Changes
train.py
andval.py
scripts now usecallbacks.run
instead of individual callback methods likeon_pretrain_routine_end()
.Callbacks
class inutils/callbacks.py
is refactored to remove individual methods tied to specific events and add a universalrun
method.Callbacks
class constructor and other methods that were previously used to run callbacks.🎯 Purpose & Impact