Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant ComputeLoss code #4701

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

zhiqwang
Copy link
Contributor

@zhiqwang zhiqwang commented Sep 8, 2021

Because ComputeLoss does not inherit from other classes.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improvement in loss computation in Ultralytics' YOLOv5 model.

πŸ“Š Key Changes

  • Removed the unnecessary super() call from the ComputeLoss class constructor.

🎯 Purpose & Impact

  • Purpose: The PR seems to streamline the loss class by eliminating a redundant superclass initialization, which wasn't required.
  • Impact: This change might slightly improve the initialization performance of the ComputeLoss class and reduce potential confusion about inheritance hierarchy for developers working with the codebase.
  • User Benefit: Users of YOLOv5 will likely not notice any direct changes, but developers can experience a cleaner and potentially less error-prone codebase. πŸ› οΈβœ¨

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹ Hello @zhiqwang, thank you for submitting a πŸš€ PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • βœ… Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature  # <----- replace 'feature' with local branch name
git rebase upstream/master
git push -u origin -f
  • βœ… Verify all Continuous Integration (CI) checks are passing.
  • βœ… Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee

@glenn-jocher glenn-jocher changed the title Remove redundant code Remove redundant ComputeLoss code Sep 8, 2021
@glenn-jocher glenn-jocher merged commit 8e5f9dd into ultralytics:master Sep 8, 2021
@glenn-jocher
Copy link
Member

@zhiqwang PR is merged. Thank you for your contributions to YOLOv5 πŸš€ and Vision AI ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants