-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update get_loggers()
#4854
Merged
Merged
Update get_loggers()
#4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glenn-jocher
force-pushed
the
update/logging
branch
2 times, most recently
from
September 18, 2021 14:42
42b92f0
to
b191ace
Compare
glenn-jocher
changed the title
Transition
Update Sep 18, 2021
print()
to LOGGER.info()
get_loggers()
glenn-jocher
force-pushed
the
update/logging
branch
from
September 18, 2021 15:44
acf3482
to
b191ace
Compare
This was referenced Nov 2, 2021
Merged
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
* Update `set_logging()` * Update export.py * pre-commit fixes * Update LoadImages * Update LoadStreams * Update print_args * Single LOGGER definition * yolo.py fix Co-authored-by: pre-commit <pre-commit@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π οΈ PR Summary
Made with β€οΈ by Ultralytics Actions
π Summary
This PR refactors logging in the YOLOv5 project to use a consistent logging pattern.
π Key Changes
print()
statements withLOGGER
calls for structured logging.LOGGER
definitions in individual files, referencing a commonLOGGER
instead.set_logging()
calls, assuming logging is set centrally.set_logging()
function and LOGGER initialization intoutils/general.py
for shared use.π― Purpose & Impact