Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

”cv2.imencode“ image-save-paths which have Chinese name fix #7235

Closed
wants to merge 3 commits into from

Conversation

yeshanliu
Copy link
Contributor

@yeshanliu yeshanliu commented Apr 1, 2022

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improved image saving functionality in YOLOv5's detection script.

📊 Key Changes

  • Altered the method of saving images from cv2.imwrite() to cv2.imencode().tofile().

🎯 Purpose & Impact

  • 🛠️ The purpose of this change is to enhance compatibility and reliability when saving images across different operating systems and file systems.
  • 🚀 Potential impact includes smoother user experience due to less chance of save errors, particularly on systems where cv2.imwrite() might encounter issues with file paths or permissions.
  • 💾 Users should notice no difference in their workflow except for a potential reduction in save-related issues.

@yeshanliu
Copy link
Contributor Author

#6979 fix the loading problem, this PR fix the save problem.

@yeshanliu
Copy link
Contributor Author

#7139 already fix this.

@yeshanliu yeshanliu closed this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant