-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DB] Potential Bug: sending NULL via umami.trackView(String, NULL) #649
Labels
bug
Something isn't working
Comments
That's def a bug, we should guard against that. |
foxytocin
added a commit
to foxytocin/umami
that referenced
this issue
May 6, 2021
prevents crashes if NULL is entered as a referrer in the database. Does not guard against submitting NULL to the database.
foxytocin
added a commit
to foxytocin/umami
that referenced
this issue
May 6, 2021
as refFilter, urlFilter is expanded checking agains url !== null.
mikecao
added a commit
that referenced
this issue
May 13, 2021
Enhancement of issue #649: also checking agains NULL in urlFilter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is possible to accidentally write NULL to the database. Did so accidentally for [referrer] value.
umami.trackView(url, [referrer])
When displaying the details page with the referrer statistics in the browser, this leads to the following error
Browser: 'An unexpected error has occurred.'
Console:
Fantastic project, best regards
The text was updated successfully, but these errors were encountered: