Fix Pages filter when URL has a trailing slash #630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #606 as discussed there. It's not uncommon for URLs to have a trailing slash and this format is used for instance by Ghost CMS; thus it can cause issues with the way Umami clears URLs for its filtering function (requests do not have a trailing slash so they return empty results).
Tried this (very) small change myself and everything seems fine!
EDIT: After some thinking I think it was there in the first place to prevent mixing up trail & non-trail URLs. Normally this shouldn't be an issue as it should be properly handled by the website itself (in case of Ghost, it redirects non-slash to slash).
Don't hesitate to close this PR if you think there's a better way to handle this: