new stick top position for rte toolbar if tabs are present, issue #11870

[markadrake]

Prerequisites

• I have added steps to test this contribution in the description below

This PR fixes #11870

Description

The tab nav bar takes up a height of 50px. So we need to adjust the sticky top position for the RTE toolbar accordingly.

I updated this:

.umb-rte .mce-top-part {
	position: sticky;
	top: 0;
}

To this:

.umb-rte .mce-top-part {
	position: sticky;
	top: 0;

  umb-editor-tab-bar ~ div & {
    top: 50px;
  }
}

I didn't see an easier way to detect whether the RTE is contained inside of a tab. So I used the sibling selector.

Recordings

The following recordings show two use cases.

Left side shows an RTE on the page under a tab.

Right side shows an RTE with no tabs.

Desktop:

umbraco-issue-11870.mp4

Mobile:

umbraco-issue-11870-mobile.mp4

[umbrabot]

Hi there @markadrake, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[nathanwoulfe]

Heya @markadrake this works as described, thank you. Ideally we wouldn't need the 50px fixed height, but the alternatives are not-insignificant chunks of change... Quick fixes are great!