Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toggle fit content #874

Closed
wants to merge 2 commits into from
Closed

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jul 26, 2024

Description

In some parts of the backoffice, when toggle as no label, when placed inside flexbox container or 100% width of uui-toggle which stretch label as well, so not only toggle + text in clickable, but also a large part of to whitespace area.

Can be seen a toggle properties in content workspace or in listview bulk actions.

Not sure this is the best option. Alternative display: inline-flex on label instead.

When inside flexbox container it could add margin-right: auto; to each toggle so it doesn't stretch to size on flexbox container.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Can be seen a toggle properties in content workspace or in listview bulk actions.

Screenshots (if appropriate)

image

image

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link

sonarcloud bot commented Aug 20, 2024

@nielslyngsoe
Copy link
Member

Hi @bjarnef

As always thanks for your attention to this!

As you mention you self you weren't sure about the solution. I worked a bit with your PR but went to the solution of setting the label slot to display block.

This also fixes the same problem for checkbox.

There is a PR here:
#890

With that I will close this one. :-)

@bjarnef bjarnef deleted the patch-1 branch August 20, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants