Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding management api docs with some examples #5925

Merged
merged 78 commits into from
Mar 27, 2024
Merged

adding management api docs with some examples #5925

merged 78 commits into from
Mar 27, 2024

Conversation

alina-tincas
Copy link
Contributor

Description

What did you add/update/change?

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

CMS v14 beta+

Deadline (if relevant)

When should the content be published?
anytime

@alina-tincas alina-tincas requested a review from Migaroez March 7, 2024 09:27
alina-tincas
alina-tincas commented Mar 7, 2024
View reviewed changes
Copy link
Contributor Author

@alina-tincas alina-tincas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing some vale errors

14/umbraco-cms/extending-cms/custom-swagger-api.md Outdated Show resolved Hide resolved
14/umbraco-cms/reference/management-api/README.md Outdated Show resolved Hide resolved
@alina-tincas alina-tincas requested a review from eshanrnh March 7, 2024 09:33
eshanrnh
eshanrnh requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, that was quite a PR to review. 🙂 I have provided my suggestions on style guide, simplifying some sentences, highlighting stuff in images and so on.

Let me know if something doesn't make sense 💪

14/umbraco-cms/reference/custom-swagger-api.md Outdated Show resolved Hide resolved
14/umbraco-cms/reference/custom-swagger-api.md Outdated Show resolved Hide resolved
14/umbraco-cms/reference/custom-swagger-api.md Outdated Show resolved Hide resolved
14/umbraco-cms/reference/custom-swagger-api.md Outdated Show resolved Hide resolved
14/umbraco-cms/reference/custom-swagger-api.md Outdated Show resolved Hide resolved
14/umbraco-cms/reference/management-api/postman-setup-swagger.md Outdated Show resolved Hide resolved
14/umbraco-cms/reference/management-api/postman-setup-swagger.md Outdated Show resolved Hide resolved
14/umbraco-cms/reference/management-api/postman-setup-swagger.md Outdated Show resolved Hide resolved
14/umbraco-cms/reference/management-api/postman-setup-swagger.md Outdated Show resolved Hide resolved
14/umbraco-cms/reference/management-api/postman-setup-swagger.md Outdated Show resolved Hide resolved
alina-tincas and others added 16 commits March 8, 2024 11:31
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/custom-swagger-api.md
1b74f9e 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/custom-swagger-api.md
e0cbbc4 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/custom-swagger-api.md
6d17b4c 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/management-api/postman-setup-swagger.md
9deb125 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/custom-swagger-api.md
f337aa3 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/custom-swagger-api.md
0714c95 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/custom-swagger-api.md
c54b7e8 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/management-api/README.md
319eb0f 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/management-api/README.md
4ea4b3b 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/management-api/README.md
32c5e39 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/management-api/postman-setup-swagger.md
21fb47e 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/management-api/postman-setup-swagger.md
2935e9f 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/management-api/postman-setup-swagger.md
a3ac136 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/management-api/postman-setup-swagger.md
6d73d7f 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/management-api/postman-setup-swagger.md
c0ec278 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas @eshanrnh
Update 14/umbraco-cms/reference/management-api/postman-setup-swagger.md
ca5cecb 
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
eshanrnh
eshanrnh approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @alina-tincas 💪👏

@alina-tincas
Copy link
Contributor Author

Thank you for all the feedback @eshanrnh, @kjac and @Migaroez #h5YR

All the feedback has been added to the articles, so am merging this in 🙌 ❤️

@alina-tincas alina-tincas merged commit 614eb09 into main Mar 27, 2024
30 of 31 checks passed
@alina-tincas alina-tincas deleted the create-management-api-article branch March 27, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjac kjac kjac left review comments

@eshanrnh eshanrnh eshanrnh approved these changes

@Migaroez Migaroez Awaiting requested review from Migaroez

Assignees
No one assigned
Labels
category/umbraco-cms category/umbraco-new-backoffice release/14.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alina-tincas @kjac @eshanrnh