Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to MNTP article #6247

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

erikjanwestendorp
Copy link
Contributor

Description

Add a note to MNTP article as suggested here: #5533 (comment)

Type of suggestion

  • New content

Product & version (if relevant)

Umbraco v10, 12, 13 & 14

@erikjanwestendorp
Copy link
Contributor Author

@sofietoft Added a little note as suggested. Please let me know if the text is ok, then I can update the other articles as well.

@eshanrnh
Copy link
Contributor

eshanrnh commented Jul 9, 2024

Thanks for the PR, @erikjanwestendorp 🙌 We will take a look at it as soon as we can 💪

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good, @erikjanwestendorp 🙌 Please feel free to add the Note in other articles as well.. 👏

…in-umbraco-property-editors/multinode-treepicker.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@erikjanwestendorp
Copy link
Contributor Author

erikjanwestendorp commented Jul 9, 2024

@eshanrnh Thanks for the review, just updated the PR with your suggestions.

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the Note formatting to match Gitbook's markdown format: https://docs.gitbook.com/content-editor/blocks/hint#representation-in-markdown

erikjanwestendorp and others added 3 commits July 9, 2024 11:27
…in-umbraco-property-editors/multinode-treepicker.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
…in-umbraco-property-editors/multinode-treepicker.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
…in-umbraco-property-editors/multinode-treepicker.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@eshanrnh
Copy link
Contributor

eshanrnh commented Jul 9, 2024

Wow, that was super quick 👏

@eshanrnh eshanrnh merged commit 8d1b341 into umbraco:main Jul 9, 2024
11 checks passed
@erikjanwestendorp erikjanwestendorp deleted the add-note-to-mntp-article branch July 9, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants