Porting old Umbraco API Controller [Block Grid Editor] #6510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @erikjanwestendorp ! 💪 |
sofietoft
reviewed
Oct 8, 2024
There was a problem hiding this comment.
I've had a chance to test this out, and I can only get it to compile if I do not make the changes you're adding to the BlockGridElementData (line 613) in the Model..cs file 🤔
It gives me the following error: Property or indexer 'BlockGridElementData.Data' cannot be assigned to -- it is read only
Perhaps it is not needed to change this method? 🤔
|
Did you see my comments on this one, @erikjanwestendorp ? 😄 |
|
@sofietoft sorry for the delay on this one! 🙈 Just updated the PR 😄 |
|
Everything checks out 😄 🎉 Thanks again @erikjanwestendorp ! I'll get this merged right away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR belongs to: #6466.
UmbracoApiControllertoControllerBlockGridElementData(Due to serialization issues)css(prevents style guide warnings, I think it is good to be careful with capitalization here because of case sensitive hosting environments)Type of suggestion
Product & version (if relevant)
Umbraco CMS v14 & 15