Update path-too-long-exception.md #6569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed database query to show media items longer than 80 characters. Previous query showed all media now you only get the media you need to edit.
|
Thanks for the PR @Abdjulaziz ! Makes sense to change this query 💪 Reading the steps that comes after running the query.. would it make sense to update those as well? What do you think? |
|
I'll look into that and fix it 👍🏻 Just noticed there's a little bit more that can be improved |
smal edit - no further changes needed
|
@sofietoft had to test something and ask internally to see if the steps were correct and they were so I did a small change to the text and removed some things |
sofietoft
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Looks great @Abdjulaziz ! 💪
I just have a single tiny suggestion.
umbraco-cloud/troubleshooting/deployments/path-too-long-exception.md
Outdated
Show resolved
Hide resolved
|
Sound good |
|
Thanks again for the PR @Abdjulaziz ! 💪 I'll get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed Database query
What did you add/update/change?
Changed database query to show media items longer than 80 characters. Previous query showed all media now you only get the media you need to edit.
Type of suggestion
Product & version (if relevant)
Deadline (if relevant)
When should the content be published?
As soon as possible