-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename listview.md to collectionview.md and update its terminology #6571
Conversation
Thanks for the PR @caronvincent ! 💪 I noticed from the UI in a 14 project, that the Property Editor is called "Collection" and not "Collection View" 🤔 I think we should update it to "Collection" 😄 You up for it? Also, you mention in your description, that you're also making some changes to Content App vs Workspace View. |
@sofietoft Thank you for the feedback.
To be clear on what you'd like me to do: since the backoffice refers to "Collection Property Editor" and not "Collection View Property Editor", all mentions of "Collection View" that I made in my PR should be changed to just "Collection" instead?
In collectionview.md (formerly listview.md), all mentions of "Content App" have been replaced by "Workspace View". |
Yes, please replace all "Collection View"s with "Collection". Thanks for clearing up about the Content App mentions! |
Understood, I will update mentions of "Collection View" in favor of "Collection". I will limit this PR to this particular file, but it may be a good idea to create a new issue asking contributors to update mentions of "Content App" in favor of "Workspace View" across the entire documentation. It would make for an easy Hacktoberfest grab, much like the issue I am addressing with this PR. |
That is very true and a great idea. |
…" to "collection" in documentation
I have pushed commit f7206cc to fix the terminology as discussed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @caronvincent 🙌
I've added a couple of suggestions to shorten a couple of sentences.
Also, we'll need a redirect for the renamed article.
The following line should be added to the bottom of the redirect list in the .gitbook.yaml
file within the 14/umbraco-cms
directory:
fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/listview: fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/collection.md
...fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/collectionview.md
Outdated
Show resolved
Hide resolved
...cms/fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/collection.md
Outdated
Show resolved
Hide resolved
...cms/fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/collection.md
Outdated
Show resolved
Hide resolved
Done! |
Excellent! Let's get this one merged then 😄 Thanks again for making this PR helping us getting this up to date 💪 MUCH appreciated! |
Thanks again @caronvincent! Just a hint: as you may know, this PR qualifies for Umbraco's Hacktoberfest participation for which you can earn rewards. |
Description
What did you add/update/change?
The aim of this pull request is to update the contents of the List View documentation page to use the updated terminology from Umbraco CMS 14, where "List view" is now known as "Collection view" and "Content App" is now known as "Workspace View".
Type of suggestion
Product & version (if relevant)
Umbraco CMS >=14
Deadline (if relevant)
When should the content be published?
N/A
Notes
The Alias has not been changed from
Umbraco.ListView
as it appears to still be in use in the backoffice.Some screenshots will eventually need to be updated when the backoffice uses the new terminology as well.
Related issue
Fixes #6553