Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct usage of GetModelPropertyType and GetModelContentType methods #6579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glombek
Copy link
Contributor

@glombek glombek commented Oct 22, 2024

Description

I corrected the usage of the Models Builder GetModelPropertyType and GetModelContentType methods to include the publishedSnapshotAccessor parameter which has been required for a few Umbraco versions now.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

v9-v13 (<v8 and v14 untested)

Deadline (if relevant)

N/A

@sofietoft
Copy link
Contributor

Thanks for the PR @glombek ! 💪

I'll make sure we get this reviewed as soon as possible!

@sofietoft sofietoft added the review/dteam Use this label if an internal D-team review is required label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/umbraco-cms review/dteam Use this label if an internal D-team review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants