Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified steps in Major upgrades Cloud article #6718

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Conversation

eshanrnh
Copy link
Contributor

@eshanrnh eshanrnh commented Dec 3, 2024

Description

Removed screenshots, made the steps concise, fixed vale error of long sentence in Note

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Cloud

Deadline (if relevant)

Anytime

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that we have a challenge here.

In the guide, we mention that you need to update the .NET versions. This is not necessary for ALL major upgrades - only every other Major upgrade.
So, it was necessary for 15, but it wont be for 16 and will again be necessary for 17 🤔

If you have any ideas for how we can tackle this, please let me know!

umbraco-cloud/product-upgrades/major-upgrades.md Outdated Show resolved Hide resolved
@eshanrnh
Copy link
Contributor Author

eshanrnh commented Dec 5, 2024

Thanks, @sofietoft for your review. I've made some changes based on your suggestion.

Regarding updating the .Net version, I added a decision-making step to the list. Depending on the user's target upgrade they can decide either to update or skip the step. Since Umbraco 16 and 17 are not yet released I have only added 15. Once the other versions are released, we can change it to something like this:

Determine if you need to update the .NET version:

  • For Umbraco 15 or 17: Update the to match the version set in your Cloud environment from Step 1.

  • For Umbraco 16 or other versions that do not require a .NET update: Skip this step.

Optionally, we can add a Note instead - something like:

Note: Updating the .NET version is necessary only for every other major upgrade. For example, .NET updates were required for version 15 but are not needed for version 16. The next .NET update will be required for version 17.

@sofietoft
Copy link
Contributor

Thanks for putting some thought into this!
I like the idea about having to paths to follow, but I'm just worried it becomes a little too messy - looking at the preview, it's not super clear what needs to happen 🤔
We also have this issue already in Step 1, so I think this is a general thing for the entire guide.

Also, since it's Cloud, we need to consider all versions going back to Umbraco 10, I think. At least all LTS versions and STS versions still supported. But, I also think we can get around this, without actually mentioning any specific versions regarding it.
Perhaps we link to the CMS article that lists Umbraco versions vs .NET versions: https://docs.umbraco.com/umbraco-cms/fundamentals/setup/upgrading#choose-the-correct-.net-version

How about we do this:

  • In Step 1 we add a step to determine which .NET version to use - and depending on that, the .NET version might need to be bumped.
  • Then, in Step 3, the task is to only opdate the .NET version in the TargetFramework if it was also changed in Step 1 🤔

Do you think that could work, perhaps?

@eshanrnh
Copy link
Contributor Author

eshanrnh commented Dec 9, 2024

I've updated the steps as per your suggestions. Let me know what you think 🤔

@eshanrnh
Copy link
Contributor Author

I think the steps should be clear now 😀

@eshanrnh
Copy link
Contributor Author

Awesome 🙌 I've removed references to step 1 from step 5. Hopefully 🤞its good to merge now 🙈

@eshanrnh eshanrnh merged commit fc700db into main Dec 16, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants