Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed and updated label description for blocks #6733

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Ambertvu
Copy link
Contributor

Description

Updated the block-grid-editor hint as it still contained old angularJS description. This is a bit odd but it is also referenced in the link a bit above: https://docs.umbraco.com/umbraco-cms/fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/block-editor/label-property-configuration. So this should either be completely removed, or still easily accessible for findings like it is with my PR.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

v14/v15 (new backoffice)

@sofietoft
Copy link
Contributor

Thanks for the PR @Ambertvu !
Just to make sure I understand, you're removing some mentions of AnuglarJS here, right?
Also, just to let you know, this article has yet to be verified for Umbraco 14/15.

@Ambertvu
Copy link
Contributor Author

Thanks for the PR @Ambertvu ! Just to make sure I understand, you're removing some mentions of AnuglarJS here, right? Also, just to let you know, this article has yet to be verified for Umbraco 14/15.

Correct! I've removed the AngularJS syntax and description and added a tiny example of how it can be done currently.
I've been 'out' for a while, so not sure what the implications are for the 'yet to be verified' and my pr.

@sofietoft
Copy link
Contributor

Perfect. Sounds good! Let's definitely get rid of that.

Yeah, that's fair! 😄
We have the article on a list here, and we hope to get it verified for the latest versions of Umbraco soon.

For now, I'll merge this PR.
Thanks again!

@sofietoft
Copy link
Contributor

Oh, just read the description again - you're referencing another article, the one about the label properties.
Let's definitely get that removed!

I'll add a task to get it done as soon as possible 💪
Thanks for flagging it!

@sofietoft sofietoft merged commit f5b6966 into umbraco:main Dec 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants