Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Add stats and metrics #3

Merged
merged 40 commits into from
Oct 10, 2023
Merged

Add stats and metrics #3

merged 40 commits into from
Oct 10, 2023

Conversation

vmenger
Copy link
Collaborator

@vmenger vmenger commented Oct 3, 2023

  • Add (descriptive) statistics to Dataset class
  • Add Metrics class which can compute some entity and qualfier metrics

@vmenger vmenger marked this pull request as draft October 3, 2023 15:04
@vmenger vmenger marked this pull request as ready for review October 5, 2023 14:41
Copy link
Collaborator

@rubenpeters91 rubenpeters91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, but looks good

README.md Outdated Show resolved Hide resolved
src/clin_nlp_metrics/metrics.py Outdated Show resolved Hide resolved
src/clin_nlp_metrics/metrics.py Outdated Show resolved Hide resolved


@pytest.fixture
def mctrainer_dataset():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same fixture as the other tests right? You can also import the fixtures

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, didn't think of that. Fixed

@vmenger vmenger merged commit 496f835 into main Oct 10, 2023
3 checks passed
@vmenger vmenger deleted the add-stats-and-metrics branch October 10, 2023 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants