-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Rename Lend to Supply #1106
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1106 +/- ##
=======================================
Coverage 43.54% 43.54%
=======================================
Files 65 65
Lines 8336 8336
=======================================
Hits 3630 3630
Misses 4456 4456
Partials 250 250
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Massive diff - just finished combing through the files manually.
The other proto rename PRs won't be like this. This one requires a change in vocabulary in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but left some comments and suggestions (could be applied to other places).
Moreover in some place we should add more context because supply is very general (eg: "for lending or collateral")
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Lots of renaming here - the word "lend" no longer appears except in old changelogs and the phrase "lending pool".
The major API breaks:
MsgLendAsset
->MsgSupply
QueryLoaned
->QuerySupplied
(and total loaned, other queries)LendAPY
->SupplyAPY
Lender
->Supplier
field in some placesIf looking for API breaking changes, view the proto file diffs first.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...