Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Rename Lend to Supply #1106

Merged
merged 18 commits into from
Jul 5, 2022
Merged

refactor!: Rename Lend to Supply #1106

merged 18 commits into from
Jul 5, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Jul 5, 2022

Lots of renaming here - the word "lend" no longer appears except in old changelogs and the phrase "lending pool".

The major API breaks:

  • MsgLendAsset -> MsgSupply
  • QueryLoaned -> QuerySupplied (and total loaned, other queries)
  • LendAPY -> SupplyAPY
  • Field name Lender -> Supplier field in some places

If looking for API breaking changes, view the proto file diffs first.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #1106 (e321079) into main (dc5a0c0) will not change coverage.
The diff coverage is 34.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1106   +/-   ##
=======================================
  Coverage   43.54%   43.54%           
=======================================
  Files          65       65           
  Lines        8336     8336           
=======================================
  Hits         3630     3630           
  Misses       4456     4456           
  Partials      250      250           
Impacted Files Coverage Δ
x/leverage/client/cli/query.go 0.00% <0.00%> (ø)
x/leverage/client/cli/tx.go 0.00% <0.00%> (ø)
x/leverage/keeper/grpc_query.go 5.77% <0.00%> (ø)
x/leverage/keeper/loaned.go 0.00% <0.00%> (ø)
x/leverage/keeper/msg_server.go 0.84% <0.00%> (ø)
x/leverage/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/leverage/types/tx.go 0.00% <0.00%> (ø)
x/leverage/types/token.go 35.59% <40.00%> (ø)
x/leverage/keeper/invariants.go 57.57% <50.00%> (ø)
x/leverage/types/codec.go 41.93% <50.00%> (ø)
... and 6 more

@toteki toteki changed the title chore!: Rename Lend to Supply refactor!: Rename Lend to Supply Jul 5, 2022
@toteki toteki marked this pull request as ready for review July 5, 2022 21:01
@toteki toteki requested review from a team as code owners July 5, 2022 21:01
Copy link
Member Author

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive diff - just finished combing through the files manually.

The other proto rename PRs won't be like this. This one requires a change in vocabulary in the docs.

Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but left some comments and suggestions (could be applied to other places).
Moreover in some place we should add more context because supply is very general (eg: "for lending or collateral")

docs/architecture/ADR-003-borrow-assets.md Outdated Show resolved Hide resolved
proto/umee/leverage/v1/leverage.proto Outdated Show resolved Hide resolved
proto/umee/leverage/v1/tx.proto Outdated Show resolved Hide resolved
proto/umee/leverage/v1/tx.proto Outdated Show resolved Hide resolved
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
toteki and others added 4 commits July 5, 2022 14:44
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@toteki toteki merged commit 1caed7c into main Jul 5, 2022
@toteki toteki deleted the adam/proto branch July 5, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants