-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove proto getters #1125
Conversation
Does this need to go to changelogs? |
No changelog needed in my opinion since observable behavior is unaffected |
I will add changelog update |
I added labels and changed type prefix to |
Thanks for quick review! |
We don't need to add labels in PRs linked to issues. If PR is not linked to issue, then we can use it as a "task" by adding to a board - only then we need to add labels.
Thanks, makes sense. |
Codecov Report
@@ Coverage Diff @@
## main #1125 +/- ##
=======================================
Coverage 43.82% 43.82%
=======================================
Files 65 65
Lines 8393 8393
=======================================
Hits 3678 3678
Misses 4472 4472
Partials 243 243
|
Description
closes: #1114
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...