Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding checkers util package #1212

Merged
merged 3 commits into from
Aug 4, 2022
Merged

feat: adding checkers util package #1212

merged 3 commits into from
Aug 4, 2022

Conversation

robert-zaremba
Copy link
Member

Description

Util package to remove repetitions in sdk.Msg interface implementation (ValidateBasic and GetSigners).

This package can be extended in the future to provide more common check / validation functions.

Ref: #1194


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba requested a review from a team as a code owner August 4, 2022 10:09
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move validateSenderAndAsset to checkers package?
either way works for me ^^

@RafilxTenfen RafilxTenfen linked an issue Aug 4, 2022 that may be closed by this pull request
4 tasks
@robert-zaremba
Copy link
Member Author

Maybe move validateSenderAndAsset to checkers package?

I think it won't be used outside of leverage messages. If it will then we will move it.

@mergify mergify bot merged commit cb1f5c9 into main Aug 4, 2022
@mergify mergify bot deleted the robert/checkers branch August 4, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leverage: (HAL-06) DUPLICATED ERROR CHECKS
2 participants