Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement MaxSupply #1319

Merged
merged 56 commits into from
Sep 7, 2022
Merged

feat: implement MaxSupply #1319

merged 56 commits into from
Sep 7, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Aug 31, 2022 •
edited
Loading

Description

This implements one of the token safety parameters on the leverage checklist.

closes: #1227

Author Checklist

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

toteki added 30 commits August 25, 2022 00:04
@toteki
supply and withdraw tests
ca8df09
@toteki
err--
d17672e
@toteki
make proto-all
3f6e746
@toteki
error improvements and fix cascading client test error DEVX
18ad3f9
@toteki
TestCollateralize
01a0d9d
@toteki
++
55e0242
@toteki
TestDe+Collateralize
3ac25d8
@toteki
case++
fb2465d
@toteki
borrow test + more cases
196a2dd
@toteki
add invariant checks to every msg test case
0c89068
@toteki
move files
a7c28ad
@toteki
++
c24c19b
@toteki
TestRepay
7bf90ef
@toteki
--
da7a29d
@toteki
Liquidate single-denom test cases
8bdbc1f
@toteki
liquidate cases
29075d0
@toteki
--
f4d3fbf
@toteki
remove setupAccount and initBorrowScenario
b6c065b
@toteki
Merge branch 'main' into adam/tests
e0f12e0
@toteki
imports
c317fae
@toteki
lint++
84b454b
@toteki
fix test
137b60b
@toteki
++
16f6087
@toteki
cl++
c951541
@toteki
remove unnecessary interface
abc1520
@toteki
move function
58d3dab
@toteki
Merge branch 'main' into adam/tests
c38f47f
@toteki
apply s.app, s.ctx, and s.Require() shorthands
357b4c3
@toteki
Merge branch 'adam/tests' of github.com:umee-network/umee into adam/t…
b0058d0 
…ests
@toteki
apply coin shorthand in keeper_test package
2d7c253
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022 •
edited
Loading

Codecov Report

Merging #1319 (2bd1d57) into main (e9782df) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
- Coverage   52.09%   52.09%   -0.01%     
==========================================
  Files          69       69              
  Lines        6816     6828      +12     
==========================================
+ Hits         3551     3557       +6     
- Misses       2988     2992       +4     
- Partials      277      279       +2
Impacted Files Coverage Δ
x/leverage/keeper/keeper.go 65.92% <50.00%> (-0.75%) ⬇️

Base automatically changed from adam/tests to main September 1, 2022 15:00
@toteki toteki changed the title DNM: implement various token limits feat: implement MaxSupply Sep 1, 2022
@toteki
Copy link
Member Author

toteki commented Sep 1, 2022 •
edited
Loading

Note: this will stay draft while we decide if MaxSupply will remain a flat amount, or be changed to a share of USD value.

Edit: R4R - keeping the simple version for v3

@toteki toteki marked this pull request as ready for review September 2, 2022 18:26
@toteki toteki requested review from a team as code owners September 2, 2022 18:26
@robert-zaremba robert-zaremba mentioned this pull request Sep 6, 2022
Open
4 tasks
robert-zaremba
robert-zaremba requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use share value with a minimum total collateral to trigger the limitation (can be hardcoded in v3 as 500k I would say - in other words, the MaxSupply check will be triggered only if TotalAllSuply is >= 500k USD)

x/leverage/fixtures/token.go Outdated Show resolved Hide resolved
x/leverage/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/leverage/keeper/keeper_test.go Outdated Show resolved Hide resolved
toteki and others added 4 commits September 6, 2022 13:07
@toteki @robert-zaremba
suggestion++
4f3cf85 
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@toteki @robert-zaremba
suggestion++
a758524 
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@toteki
follow suggested underscore
a2a3eae
@toteki
Merge branch 'main' into adam/limits
8453918
@toteki toteki requested a review from a team as a code owner September 6, 2022 20:42
robert-zaremba
robert-zaremba approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following our discussion, we won't use that functionality. We can:

  • leave this PR in draft
  • or merge and add appropriate comments in the code
    Do as you prefer.

@mergify mergify bot merged commit 5cbf948 into main Sep 7, 2022
@mergify mergify bot deleted the adam/limits branch September 7, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafilxTenfen RafilxTenfen RafilxTenfen approved these changes

@robert-zaremba robert-zaremba robert-zaremba approved these changes

Assignees
No one assigned
Labels
A:Automerge C:x/leverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit token supply (token.MaxSupply)
4 participants
@toteki @codecov-commenter @robert-zaremba @RafilxTenfen