Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slash window progress reset #1471

Merged
merged 7 commits into from
Oct 7, 2022
Merged

fix: slash window progress reset #1471

merged 7 commits into from
Oct 7, 2022

Conversation

adamewozniak
Copy link
Collaborator

Description

Fixes an issue where the slash window progress doesn't reset at the end of the slashing window


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@adamewozniak
Copy link
Collaborator Author

Just was checking on mainnet & had to slip this one in before I got on the plane

@adamewozniak adamewozniak marked this pull request as ready for review October 5, 2022 02:21
@adamewozniak adamewozniak requested review from a team as code owners October 5, 2022 02:21
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #1471 (8da0486) into main (4519faf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1471   +/-   ##
=======================================
  Coverage   52.75%   52.75%           
=======================================
  Files          71       71           
  Lines        6750     6750           
=======================================
  Hits         3561     3561           
  Misses       2920     2920           
  Partials      269      269           
Impacted Files Coverage Δ
x/oracle/keeper/grpc_query.go 97.91% <100.00%> (ø)

@mergify mergify bot merged commit ed8e069 into main Oct 7, 2022
@mergify mergify bot deleted the woz/oracle-slash-window branch October 7, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants