Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(historacle): Update proto messages and remove BlockNum from medians #1588

Merged
merged 6 commits into from
Nov 15, 2022

Conversation

zarazan
Copy link
Contributor

@zarazan zarazan commented Nov 14, 2022

Description

  • Remove BlockNum from median/medianDeviation.
  • Only use the Historacle price proto message for genesis - otherwise use just a sdk.Dec object.
  • Add medianDeviation to genesis
  • Update medians from sdk.Dec to ExchangeRateTuple in GenesisState

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@zarazan zarazan changed the title remove blocknum from median/medianDeviation feat(historacle): Update historacle proto messages Nov 14, 2022
@zarazan zarazan changed the title feat(historacle): Update historacle proto messages feat(historacle): Update proto messages and remove BlockNum from medians Nov 14, 2022
@zarazan zarazan marked this pull request as ready for review November 14, 2022 19:20
@zarazan zarazan requested review from a team as code owners November 14, 2022 19:20
@codecov-commenter
Copy link

Codecov Report

Merging #1588 (fcedd62) into main (1813b2e) will decrease coverage by 0.09%.
The diff coverage is 82.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1588      +/-   ##
==========================================
- Coverage   55.33%   55.24%   -0.10%     
==========================================
  Files          66       66              
  Lines        6636     6629       -7     
==========================================
- Hits         3672     3662      -10     
- Misses       2691     2693       +2     
- Partials      273      274       +1     
Impacted Files Coverage Δ
x/leverage/keeper/grpc_query.go 62.68% <0.00%> (-1.50%) ⬇️
x/oracle/types/keys.go 60.00% <0.00%> (ø)
x/oracle/keeper/historic_price.go 93.40% <92.59%> (-0.54%) ⬇️
x/leverage/keeper/keeper.go 66.41% <100.00%> (+0.12%) ⬆️

@zarazan zarazan merged commit f331b53 into main Nov 15, 2022
@zarazan zarazan deleted the zarazan/historacle-proto-updates branch November 15, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants