Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leverage gov proposal migrations #1640

Merged
merged 18 commits into from
Dec 5, 2022
Merged

fix: leverage gov proposal migrations #1640

merged 18 commits into from
Dec 5, 2022

Conversation

robert-zaremba
Copy link
Member

Description

closes: #1627


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba requested review from a team as code owners December 1, 2022 23:49
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #1640 (94d8876) into main (7e9ab7a) will increase coverage by 0.05%.
The diff coverage is 66.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1640      +/-   ##
==========================================
+ Coverage   54.05%   54.11%   +0.05%     
==========================================
  Files          71       72       +1     
  Lines        7150     7200      +50     
==========================================
+ Hits         3865     3896      +31     
- Misses       2988     3004      +16     
- Partials      297      300       +3     
Impacted Files Coverage Δ
x/leverage/keeper/limits.go 13.88% <0.00%> (-1.74%) ⬇️
x/leverage/types/codec.go 41.17% <0.00%> (-7.10%) ⬇️
x/leverage/types/msgs.go 6.34% <ø> (+1.73%) ⬆️
x/leverage/types/proposal.go 33.33% <33.33%> (ø)
x/leverage/keeper/keeper.go 66.41% <50.00%> (ø)
x/leverage/keeper/oracle.go 64.13% <71.42%> (+1.05%) ⬆️
x/leverage/keeper/liquidate.go 84.00% <86.66%> (+0.96%) ⬆️
x/leverage/client/tests/tests.go 100.00% <100.00%> (ø)
x/leverage/keeper/grpc_query.go 62.68% <100.00%> (ø)
... and 2 more

@robert-zaremba robert-zaremba force-pushed the robert/fix-leverage-gov branch from 1d2a34c to 46dea3b Compare December 2, 2022 17:14
app/upgradev3_3/migrate.go Outdated Show resolved Hide resolved
app/upgrades.go Outdated Show resolved Hide resolved
@robert-zaremba robert-zaremba force-pushed the robert/fix-leverage-gov branch from 0d6943d to d596d56 Compare December 2, 2022 18:31
@toteki
Copy link
Member

toteki commented Dec 2, 2022

lint: don't use an underscore in package name (upgrade3_3)

app/upgradev3_3/migrate.go Outdated Show resolved Hide resolved
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the package name lint is resolved, this looks good. How extensive was our local testing?

@mergify mergify bot merged commit d417ed4 into main Dec 5, 2022
@mergify mergify bot deleted the robert/fix-leverage-gov branch December 5, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gov proposal list RPC endpoint broken
3 participants