feat: add MsgMaxBorrow #1690
Merged
feat: add MsgMaxBorrow #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1690 +/- ##
==========================================
- Coverage 57.97% 57.57% -0.40%
==========================================
Files 73 73
Lines 7821 7894 +73
==========================================
+ Hits 4534 4545 +11
- Misses 2934 2996 +62
Partials 353 353
|
toteki
commented
Jan 5, 2023
toteki
commented
Jan 5, 2023
adamewozniak
approved these changes
Jan 6, 2023
| // create an additional supplier (DUMP, PUMP tokens) | ||
| surplus := s.newAccount(coin(dumpDenom, 100_000000), coin(pumpDenom, 100_000000)) | ||
| s.supply(surplus, coin(pumpDenom, 100_000000)) | ||
| s.supply(surplus, coin(dumpDenom, 100_000000)) |
There was a problem hiding this comment.
This code should be reused, rather than copied over.
| @@ -37,6 +37,7 @@ var ( | |||
| ErrLiquidationIneligible = sdkerrors.Register(ModuleName, 403, "borrower not eligible for liquidation") | |||
| ErrMaxWithdrawZero = sdkerrors.Register(ModuleName, 404, "max withdraw amount was zero") | |||
| ErrNoHistoricMedians = sdkerrors.Register(ModuleName, 405, "insufficient historic medians available") | |||
| ErrMaxBorrowZero = sdkerrors.Register(ModuleName, 406, "max borrow amount was zero") | |||
There was a problem hiding this comment.
Why this is an error? If there is nothing more to borrow, we just return zero, rather error. Imaging smart contract just want to automatically set max borrow. It should handle zero value rather than dealing with failed transaction.
There was a problem hiding this comment.
Any supply / withdraw / borrow / etc that is a No-Op currently fails rather then succeeding with consumed gas. This follows suit
There was a problem hiding this comment.
If transaction fails, then the whole provided fee for gas is consumed anyway. So, it only makes doing composability more difficult.
Merged
17 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
… no more to borrow (#1694) ## Description ref: #1690 (comment) --- ### Author Checklist _All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues._ I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] added appropriate labels to the PR - [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist _All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items._ I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
This was referenced Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is ready before Jan 6, we can add it to
v4.0.Mimics
MsgMaxWithdrawchanges from #1642 and #1680Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...