Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add historic pricing info to leverage queries #1711

Merged
merged 5 commits into from
Jan 15, 2023
Merged

Conversation

toteki
Copy link
Member

@toteki toteki commented Jan 14, 2023

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki marked this pull request as ready for review January 14, 2023 22:15
@toteki toteki requested review from a team as code owners January 14, 2023 22:15
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2023

Codecov Report

Merging #1711 (d133e56) into main (fde1656) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
+ Coverage   58.10%   58.18%   +0.07%     
==========================================
  Files          73       73              
  Lines        7896     7911      +15     
==========================================
+ Hits         4588     4603      +15     
  Misses       2953     2953              
  Partials      355      355              
Impacted Files Coverage Δ
x/leverage/types/msgs.go 9.09% <ø> (ø)
x/leverage/client/tests/tests.go 100.00% <100.00%> (ø)
x/leverage/keeper/grpc_query.go 65.78% <100.00%> (+0.93%) ⬆️
x/oracle/keeper/grpc_query.go 92.46% <100.00%> (+0.07%) ⬆️

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 6edb0f1 into main Jan 15, 2023
@mergify mergify bot deleted the adam/hquery branch January 15, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants