Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ibc inflow only for registered tokens #1953

Merged
merged 10 commits into from
Mar 29, 2023
Merged

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Mar 27, 2023

Description

Allowing ibc inflow for only registered tokens

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@gsk967 gsk967 marked this pull request as ready for review March 27, 2023 05:50
@gsk967 gsk967 requested a review from a team as a code owner March 27, 2023 05:50
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@cde697d). Click here to learn what that means.
The diff coverage is 55.55%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1953   +/-   ##
=======================================
  Coverage        ?   66.86%           
=======================================
  Files           ?      100           
  Lines           ?     7950           
  Branches        ?        0           
=======================================
  Hits            ?     5316           
  Misses          ?     2221           
  Partials        ?      413           
Impacted Files Coverage Δ
x/uibc/quota/keeper/quota.go 40.39% <ø> (ø)
x/uibc/quota/keeper/relay.go 0.00% <0.00%> (ø)
x/uibc/ics20/ibc_module.go 37.50% <55.55%> (ø)
util/ibc/ibc.go 58.82% <58.82%> (ø)

util/ibc/ibc.go Show resolved Hide resolved
util/ibc/ibc.go Show resolved Hide resolved
x/uibc/ics20/ibc_module.go Outdated Show resolved Hide resolved
x/uibc/ics20/ibc_module.go Show resolved Hide resolved
@gsk967 gsk967 requested a review from robert-zaremba March 28, 2023 16:01
x/uibc/ics20/ibc_module_test.go Outdated Show resolved Hide resolved
@gsk967 gsk967 added this pull request to the merge queue Mar 29, 2023
Merged via the queue into main with commit 7d9f5f9 Mar 29, 2023
@gsk967 gsk967 deleted the sai/allow_inflow_reg_tokens branch March 29, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants