Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: genesis type cast #1968

Merged
merged 3 commits into from
Mar 31, 2023
Merged

fix: genesis type cast #1968

merged 3 commits into from
Mar 31, 2023

Conversation

kosegor
Copy link
Contributor

@kosegor kosegor commented Mar 30, 2023

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #1968 (112e720) into main (89ee005) will increase coverage by 1.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1968      +/-   ##
==========================================
+ Coverage   66.92%   68.09%   +1.17%     
==========================================
  Files         100      100              
  Lines        8017     8017              
==========================================
+ Hits         5365     5459      +94     
+ Misses       2232     2140      -92     
+ Partials      420      418       -2     
Impacted Files Coverage Δ
x/leverage/keeper/genesis.go 87.23% <100.00%> (+78.72%) ⬆️

... and 1 file with indirect coverage changes

@kosegor kosegor marked this pull request as ready for review March 31, 2023 01:13
@kosegor kosegor requested review from a team as code owners March 31, 2023 01:13
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for catching this fix

@toteki toteki added the T:Bug A regression or bug in the Umee codebase. label Mar 31, 2023
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
@kosegor kosegor added this pull request to the merge queue Mar 31, 2023
Merged via the queue into main with commit 208d607 Mar 31, 2023
@kosegor kosegor deleted the egor/fix-genesis branch March 31, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/leverage T:Bug A regression or bug in the Umee codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants