Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quota zero check #1973

Merged
merged 5 commits into from
Apr 5, 2023
Merged

feat: quota zero check #1973

merged 5 commits into from
Apr 5, 2023

Conversation

robert-zaremba
Copy link
Member

Description

  • adding missing quota params check for unlimited transfers
  • adding unit tests.

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #1973 (11b0472) into main (98e7e93) will increase coverage by 0.38%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1973      +/-   ##
==========================================
+ Coverage   68.05%   68.43%   +0.38%     
==========================================
  Files         100      100              
  Lines        8022     8021       -1     
==========================================
+ Hits         5459     5489      +30     
+ Misses       2145     2110      -35     
- Partials      418      422       +4     
Impacted Files Coverage Δ
x/uibc/ics20/keeper/keeper.go 0.00% <ø> (ø)
x/uibc/quota/keeper/quota.go 60.66% <68.75%> (+20.26%) ⬆️
x/uibc/quota/keeper/genesis.go 100.00% <100.00%> (ø)
x/uibc/quota/keeper/grpc_query.go 76.92% <100.00%> (ø)

@robert-zaremba robert-zaremba requested a review from a team as a code owner April 4, 2023 21:31
@robert-zaremba robert-zaremba enabled auto-merge April 5, 2023 09:07
@robert-zaremba robert-zaremba added this pull request to the merge queue Apr 5, 2023
Merged via the queue into main with commit 6cc69bb Apr 5, 2023
@robert-zaremba robert-zaremba deleted the robert/quota-zero-check branch April 5, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants