-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: uibc unit tests #2021
Merged
Merged
feat: uibc unit tests #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
requested review from
kosegor,
gsk967,
toteki and
a team
and removed request for
a team
May 5, 2023 10:11
Codecov Report
@@ Coverage Diff @@
## main #2021 +/- ##
==========================================
- Coverage 75.38% 67.21% -8.17%
==========================================
Files 100 118 +18
Lines 8025 9338 +1313
==========================================
+ Hits 6050 6277 +227
- Misses 1589 2596 +1007
- Partials 386 465 +79
|
LGTM |
kosegor
approved these changes
May 5, 2023
gsk967
approved these changes
May 5, 2023
This was referenced Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finalized unit tests framework based on uibc package
intest
directory - integration tests take 2x time to setup due to dependency loadingKeeperBuilder
patter to separatesdk.Context
dependencyKeeper
should not depend on context - currently it is still there due to Oracle and Leverage interface, which will be solved in a subsequent PR using adapter.Advantages: