Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emergency group leverage #2188

Merged
merged 29 commits into from
Aug 8, 2023
Merged

Conversation

robert-zaremba
Copy link
Member

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba requested a review from a team as a code owner August 7, 2023 23:22
@robert-zaremba robert-zaremba changed the title feat: emergency group leverage and IBC integration feat: emergency group leverage Aug 7, 2023
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept looks good - probably someone else will review this once it's ready

util/checkers/number_test.go Outdated Show resolved Hide resolved
x/leverage/keeper/msg_server.go Outdated Show resolved Hide resolved
Comment on lines +133 to +135
for i := range regDenoms {
regSymbols[strings.ToUpper(regDenoms[i].SymbolDenom)] = true
}

Check warning

Code scanning / CodeQL

Iteration over map

Iteration over map may be a possible source of non-determinism
@robert-zaremba robert-zaremba requested a review from toteki August 8, 2023 11:44
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some commits - please doublecheck them

Overall looks good

Make sure to fix unit tests (probably have to use valid duplicate token) and lint

@robert-zaremba robert-zaremba requested review from gsk967 and toteki August 8, 2023 14:43
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2188 (399e31b) into main (7f05ad4) will decrease coverage by 7.24%.
Report is 172 commits behind head on main.
The diff coverage is 81.98%.

❗ Current head 399e31b differs from pull request most recent head da05bba. Consider uploading reports for the commit da05bba to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2188      +/-   ##
==========================================
- Coverage   75.38%   68.15%   -7.24%     
==========================================
  Files         100      160      +60     
  Lines        8025    11905    +3880     
==========================================
+ Hits         6050     8114    +2064     
- Misses       1589     3246    +1657     
- Partials      386      545     +159     
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
util/coin/coin.go 12.50% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/incentive/keeper/store.go 70.67% <ø> (ø)
x/incentive/keeper/unbonding.go 80.45% <ø> (ø)
x/incentive/keeper/update.go 52.11% <ø> (ø)
x/incentive/keys.go 100.00% <ø> (ø)
x/incentive/msgs.go 77.41% <ø> (-0.81%) ⬇️
x/incentive/params.go 89.28% <ø> (-10.72%) ⬇️
... and 58 more

... and 63 files with indirect coverage changes

@robert-zaremba robert-zaremba added the skip-e2e-test Skip the e2e tests label Aug 8, 2023
@robert-zaremba robert-zaremba added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit 5f8575a Aug 8, 2023
@robert-zaremba robert-zaremba deleted the robert/emergency-group-leverage branch August 8, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-e2e-test Skip the e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants