Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emergency group index update #2246

Merged
merged 12 commits into from
Sep 27, 2023
Merged

feat: emergency group index update #2246

merged 12 commits into from
Sep 27, 2023

Conversation

kosegor
Copy link
Contributor

@kosegor kosegor commented Sep 15, 2023

No description provided.

@kosegor kosegor requested a review from a team as a code owner September 15, 2023 12:53
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #2246 (d1b99c5) into main (7f05ad4) will decrease coverage by 4.71%.
Report is 246 commits behind head on main.
The diff coverage is 83.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2246      +/-   ##
==========================================
- Coverage   75.38%   70.68%   -4.71%     
==========================================
  Files         100      170      +70     
  Lines        8025    12796    +4771     
==========================================
+ Hits         6050     9045    +2995     
- Misses       1589     3152    +1563     
- Partials      386      599     +213     
Files Coverage Δ
ante/ante.go 66.66% <100.00%> (+18.45%) ⬆️
ante/fee.go 80.00% <100.00%> (+1.64%) ⬆️
ante/spam_prevention.go 75.92% <ø> (ø)
app/inflation/inflation.go 100.00% <100.00%> (ø)
util/coin/utoken.go 100.00% <100.00%> (ø)
x/incentive/client/tests/suite.go 100.00% <100.00%> (ø)
x/incentive/client/tests/tests.go 100.00% <100.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/genesis.go 92.48% <100.00%> (+79.14%) ⬆️
x/incentive/keeper/bond.go 92.50% <ø> (ø)
... and 49 more

... and 89 files with indirect coverage changes

Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left few comments

x/metoken/keeper/metoken.go Outdated Show resolved Hide resolved
x/metoken/keeper/metoken.go Show resolved Hide resolved
x/metoken/keeper/metoken.go Outdated Show resolved Hide resolved
x/metoken/keeper/metoken.go Outdated Show resolved Hide resolved
x/metoken/keeper/metoken.go Outdated Show resolved Hide resolved
x/metoken/keeper/msg_server.go Outdated Show resolved Hide resolved
x/metoken/keeper/msg_server.go Show resolved Hide resolved
util/checkers/error.go Outdated Show resolved Hide resolved
x/metoken/keeper/metoken.go Outdated Show resolved Hide resolved
x/metoken/keeper/metoken.go Outdated Show resolved Hide resolved
x/metoken/keeper/metoken.go Outdated Show resolved Hide resolved
x/metoken/keeper/metoken.go Outdated Show resolved Hide resolved
x/metoken/keeper/metoken.go Outdated Show resolved Hide resolved
x/metoken/keeper/metoken.go Outdated Show resolved Hide resolved
x/metoken/keeper/metoken.go Outdated Show resolved Hide resolved
@robert-zaremba robert-zaremba added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 19f5ab6 Sep 27, 2023
25 checks passed
@robert-zaremba robert-zaremba deleted the egor/metoken-eg branch September 27, 2023 17:49
facundomedica pushed a commit that referenced this pull request Oct 30, 2023
* eg for metoken

* pr comments

* fix

* lint

* lint

* pr comments2

* pr comments3

* Update x/metoken/keeper/metoken.go

---------

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants