Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gov special assets fix for 6.0 #2247

Merged
merged 3 commits into from
Sep 15, 2023
Merged

fix: gov special assets fix for 6.0 #2247

merged 3 commits into from
Sep 15, 2023

Conversation

toteki
Copy link
Member

@toteki toteki commented Sep 15, 2023

No description provided.

@toteki toteki requested a review from a team as a code owner September 15, 2023 14:13
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #2247 (7b4e4d8) into main (7f05ad4) will decrease coverage by 5.06%.
Report is 226 commits behind head on main.
The diff coverage is 84.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2247      +/-   ##
==========================================
- Coverage   75.38%   70.33%   -5.06%     
==========================================
  Files         100      168      +68     
  Lines        8025    12643    +4618     
==========================================
+ Hits         6050     8892    +2842     
- Misses       1589     3154    +1565     
- Partials      386      597     +211     
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
cmd/ibc_denom/main.go 0.00% <0.00%> (ø)
util/coin/coin.go 12.50% <0.00%> (ø)
util/sdkutil/msg.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/genesis.go 40.90% <ø> (ø)
x/incentive/keeper/grpc_query.go 59.18% <ø> (ø)
x/incentive/keeper/hooks.go 50.00% <ø> (ø)
x/incentive/keeper/invariants.go 0.00% <ø> (ø)
x/incentive/keeper/iter.go 84.90% <ø> (ø)
... and 51 more

... and 84 files with indirect coverage changes

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add invalid MsgGovUpdateSpecialAssets just like existed code missing some fields

Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

x/leverage/keeper/msg_server.go Show resolved Hide resolved
@toteki toteki added this pull request to the merge queue Sep 15, 2023
Merged via the queue into main with commit f56f3bf Sep 15, 2023
25 checks passed
@toteki toteki deleted the adam/fix6 branch September 15, 2023 15:49
facundomedica pushed a commit that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants