feat(oracle): add timestamp to exchange rates #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsk967
commented
Sep 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #2254 +/- ##
==========================================
- Coverage 75.38% 70.50% -4.89%
==========================================
Files 100 169 +69
Lines 8025 12735 +4710
==========================================
+ Hits 6050 8979 +2929
- Misses 1589 3155 +1566
- Partials 386 601 +215
|
There was a problem hiding this comment.
As noted in the previous review you only need new type for Genesis.
So, instead of changing ExchangeRate, keep it as is, and don't change Set/GetExchange rate. Instead, as you did in the latest version, use DenomExchangeRate (and add denom there) for Genesis.
auto-merge was automatically disabled
September 21, 2023 13:50
Merge queue setting changed
and using ExchangeRate for return types on oracle
toteki
reviewed
Sep 22, 2023
toteki
reviewed
Sep 22, 2023
toteki
reviewed
Sep 22, 2023
toteki
reviewed
Sep 22, 2023
I did not use codec for ExchangeRate because it is only just go struct and I revert the UMEE to umee in defaultParams |
toteki
reviewed
Sep 26, 2023
toteki
reviewed
Sep 26, 2023
toteki
reviewed
Sep 26, 2023
toteki
approved these changes
Sep 26, 2023
facundomedica
pushed a commit
that referenced
this pull request
Oct 30, 2023
* add timestamp to denom price * address the first review comments * add SetExchangeRateWithTimestamp func * storing rate and timestamp without denom into exg rates * renamed ExchangeRate to DenomExchangeRate on oracle genesis and using ExchangeRate for return types on oracle * address the review comments * add some tests and cli query for getting timestamps of exgrates * add tests to cli and grpc exg rates with timestamp req * fix the tests on oracle * fix the tests --------- Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
This was referenced Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...