-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: recent price mode support #2267
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2267 +/- ##
==========================================
- Coverage 75.38% 70.43% -4.96%
==========================================
Files 100 171 +71
Lines 8025 12892 +4867
==========================================
+ Hits 6050 9081 +3031
- Misses 1589 3208 +1619
- Partials 386 603 +217
|
@adam can you check why we are clearning exg_rates if we clear exg_rates then we will get @robert-zaremba WDYT about this ? We are getting this results after stopping the price-feeder but have to get old results instead of We need to use old price instead of showing error
and same with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adam Please check my comments
I am per-approving this pr
you can remove https://github.com/umee-network/umee/blob/adam/recent/x/oracle/abci.go#L57 this line in next your pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think
mode.AllowsExpired()
doesn't make sense - we should stop using deprecated features in a new code (errors.Register)
* price mode support * cl# * fix tests * change query behavior * update test * add emulated price outage to mock oracle * test++ * test++ * adjust price behavior for account summary query * message behavior tests * lint * comment * market summary uses price mdoe query * fix oracle behavior (stop clearing prices) * tests++ * tests++ * warning++
Adjust account summary query to display leverage logic prices (considering the more cautious of spot and historic generally) but allow expired prices.
Leverage transactions, and transaction-simulating queries like max borrow, reject expired prices.
Hard-codes max price age (for now) at 3 minutes for transactions' sake. Compare to current 30 second price voting window, but 3 hour historic median period