Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e test reliability #2276

Merged
merged 60 commits into from
Oct 15, 2023
Merged

fix: e2e test reliability #2276

merged 60 commits into from
Oct 15, 2023

Conversation

toteki
Copy link
Member

@toteki toteki commented Oct 9, 2023

This PR follows #2274 and contains the main attempts at improvements.

@toteki toteki changed the base branch from main to adam/e2e2 October 9, 2023 03:18
tests/e2e/setup/accounts.go Outdated Show resolved Hide resolved
Base automatically changed from adam/e2e2 to main October 10, 2023 03:57
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #2276 (56d8982) into main (7f05ad4) will decrease coverage by 4.91%.
Report is 257 commits behind head on main.
The diff coverage is 83.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2276      +/-   ##
==========================================
- Coverage   75.38%   70.48%   -4.91%     
==========================================
  Files         100      170      +70     
  Lines        8025    12880    +4855     
==========================================
+ Hits         6050     9079    +3029     
- Misses       1589     3198    +1609     
- Partials      386      603     +217     
Files Coverage Δ
ante/ante.go 66.66% <100.00%> (+18.45%) ⬆️
ante/fee.go 80.00% <100.00%> (+1.64%) ⬆️
ante/spam_prevention.go 75.92% <ø> (ø)
app/inflation/inflation.go 100.00% <100.00%> (ø)
util/coin/utoken.go 100.00% <100.00%> (ø)
x/incentive/client/tests/suite.go 100.00% <100.00%> (ø)
x/incentive/client/tests/tests.go 100.00% <100.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/genesis.go 92.48% <100.00%> (+79.14%) ⬆️
x/incentive/keeper/bond.go 92.50% <ø> (ø)
... and 45 more

... and 95 files with indirect coverage changes

@toteki toteki marked this pull request as ready for review October 12, 2023 19:38
@toteki toteki requested a review from a team as a code owner October 12, 2023 19:38
@toteki
Copy link
Member Author

toteki commented Oct 13, 2023

Skipped ibc test - we can merge this then debug that separately.

The main objective (fix account sequence issue) is solved

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsk967 gsk967 added this pull request to the merge queue Oct 15, 2023
Merged via the queue into main with commit a203b41 Oct 15, 2023
25 checks passed
@gsk967 gsk967 deleted the adam/e2speed2 branch October 15, 2023 12:07
facundomedica pushed a commit that referenced this pull request Oct 30, 2023
* delete eth dockerfiles

* move gaia funcs to gaia.go

* move metoken util out of setup folder; move oracle tests to oracle file

* function comments

* todo comments

* comments

* comments and combine some functions

* price-feeder.go

* import order

* ibc.go

* add test account

* revert and try creating accounts later

* refactor coins without string

* try with commented out

* init balance as coins, not string

* fix merge

* move vars around

* comment

* fix merge

* lower wait time

* dedicated client for test accounts

* add client to each validator

* client name

* overhaul tests to use single-mnemonic clients

* fix

* fix

* logs

* prevent division by zero

* prevent division by zero

* rename fix

* account sequence: use expcted value on retry

* fix delegation

* switch account on meToken test

* log every ibc tx

* modify logs

* logs++

* revert one addr change in ibc

* ++

* ++

* why was this working before? x2 fixed

* diagnose

* is that the last of them?

* empty commit

* oracle tests

* Revert "build(deps): Bump github.com/spf13/viper from 1.16.0 to 1.17.0 (#2275)"

This reverts commit 6b166a6.

* tidy

* exceed quota more reliably

* exceed quota more reliably

* rewrite ibc test to use reliable amounts (not > or < quota based on rounding)

* fix

* add log

* ++

* skip ibc e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants