-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: e2e test reliability #2276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toteki
commented
Oct 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #2276 +/- ##
==========================================
- Coverage 75.38% 70.48% -4.91%
==========================================
Files 100 170 +70
Lines 8025 12880 +4855
==========================================
+ Hits 6050 9079 +3029
- Misses 1589 3198 +1609
- Partials 386 603 +217
|
toteki
commented
Oct 12, 2023
toteki
commented
Oct 12, 2023
toteki
commented
Oct 12, 2023
Skipped ibc test - we can merge this then debug that separately. The main objective (fix account sequence issue) is solved |
gsk967
approved these changes
Oct 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
facundomedica
pushed a commit
that referenced
this pull request
Oct 30, 2023
* delete eth dockerfiles * move gaia funcs to gaia.go * move metoken util out of setup folder; move oracle tests to oracle file * function comments * todo comments * comments * comments and combine some functions * price-feeder.go * import order * ibc.go * add test account * revert and try creating accounts later * refactor coins without string * try with commented out * init balance as coins, not string * fix merge * move vars around * comment * fix merge * lower wait time * dedicated client for test accounts * add client to each validator * client name * overhaul tests to use single-mnemonic clients * fix * fix * logs * prevent division by zero * prevent division by zero * rename fix * account sequence: use expcted value on retry * fix delegation * switch account on meToken test * log every ibc tx * modify logs * logs++ * revert one addr change in ibc * ++ * ++ * why was this working before? x2 fixed * diagnose * is that the last of them? * empty commit * oracle tests * Revert "build(deps): Bump github.com/spf13/viper from 1.16.0 to 1.17.0 (#2275)" This reverts commit 6b166a6. * tidy * exceed quota more reliably * exceed quota more reliably * rewrite ibc test to use reliable amounts (not > or < quota based on rounding) * fix * add log * ++ * skip ibc e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #2274 and contains the main attempts at improvements.