Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding ibc quota v2 #2296

Merged
merged 31 commits into from
Nov 15, 2023
Merged

feat: adding ibc quota v2 #2296

merged 31 commits into from
Nov 15, 2023

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Oct 26, 2023

Description

We are allowing OUTFLOW IBC Transfers when either

  • Sum of all outflows of all tokens <= $1.6M
  • or Sum of all outflows of all tokens <= $1M + params.TotalInflowQuota * Sum of all inflows

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@gsk967 gsk967 changed the title feat(WIP): adding v2 ibc quota feat: adding ibc quota v2 Oct 27, 2023
@gsk967 gsk967 marked this pull request as ready for review October 27, 2023 11:39
@gsk967 gsk967 requested review from a team as code owners October 27, 2023 11:39
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2296 (19aea15) into main (7f05ad4) will decrease coverage by 4.96%.
Report is 292 commits behind head on main.
The diff coverage is 66.08%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2296      +/-   ##
==========================================
- Coverage   75.38%   70.43%   -4.96%     
==========================================
  Files         100      171      +71     
  Lines        8025    12973    +4948     
==========================================
+ Hits         6050     9137    +3087     
- Misses       1589     3225    +1636     
- Partials      386      611     +225     
Files Coverage Δ
ante/ante.go 66.66% <100.00%> (+18.45%) ⬆️
ante/fee.go 80.00% <100.00%> (+1.64%) ⬆️
ante/spam_prevention.go 75.92% <ø> (ø)
app/inflation/inflation.go 100.00% <100.00%> (ø)
app/upgradev3/migrations.go 84.21% <ø> (+5.94%) ⬆️
util/coin/utoken.go 100.00% <100.00%> (ø)
util/ibc/ibc.go 58.82% <ø> (ø)
util/sdkutil/events.go 0.00% <ø> (ø)
util/store/store.go 52.06% <ø> (+10.65%) ⬆️
util/store/unmarshal.go 42.85% <ø> (ø)
... and 40 more

... and 104 files with indirect coverage changes

Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade handler is missing. Can be done in a new PR -> in such case, please make a comment here and create a new task.

.golangci.yml Outdated Show resolved Hide resolved
proto/umee/uibc/v1/genesis.proto Outdated Show resolved Hide resolved
proto/umee/uibc/v1/quota.proto Show resolved Hide resolved
x/uibc/params.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Outdated Show resolved Hide resolved
@gsk967 gsk967 requested a review from robert-zaremba October 31, 2023 14:46
@gsk967 gsk967 enabled auto-merge November 2, 2023 10:12
app/upgrades.go Outdated Show resolved Hide resolved
app/upgrades.go Outdated Show resolved Hide resolved
x/uibc/params.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota_test.go Show resolved Hide resolved
@robert-zaremba
Copy link
Member

@gsk967 gsk967 requested a review from robert-zaremba November 3, 2023 14:39
app/upgrades.go Outdated Show resolved Hide resolved
app/upgrades.go Outdated Show resolved Hide resolved
proto/umee/uibc/v1/genesis.proto Outdated Show resolved Hide resolved
proto/umee/uibc/v1/genesis.proto Outdated Show resolved Hide resolved
proto/umee/uibc/v1/quota.proto Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota_test.go Show resolved Hide resolved
x/uibc/quota/keeper/quota_test.go Show resolved Hide resolved
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • let's don't close a comment without updating the code or responding
  • few other comments are still not resolved
  • test is missing
  • error check is missing

app/upgrades.go Outdated Show resolved Hide resolved
util/store/store.go Show resolved Hide resolved
x/uibc/README.md Outdated Show resolved Hide resolved
x/uibc/README.md Outdated Show resolved Hide resolved
x/uibc/quota/keeper/keys.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/mocks_test.go Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Show resolved Hide resolved
util/store/store.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/migrations.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/mocks_test.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota.go Show resolved Hide resolved
proto/umee/uibc/v1/quota.proto Show resolved Hide resolved
util/store/iter.go Outdated Show resolved Hide resolved
util/store/iter.go Outdated Show resolved Hide resolved
@gsk967 gsk967 added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 0a387dd Nov 15, 2023
26 of 28 checks passed
@gsk967 gsk967 deleted the sai/quota_v2 branch November 15, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants