-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding ibc quota v2 #2296
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2296 +/- ##
==========================================
- Coverage 75.38% 70.43% -4.96%
==========================================
Files 100 171 +71
Lines 8025 12973 +4948
==========================================
+ Hits 6050 9137 +3087
- Misses 1589 3225 +1636
- Partials 386 611 +225
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upgrade handler is missing. Can be done in a new PR -> in such case, please make a comment here and create a new task.
Docs have to be updated as well: https://github.com/umee-network/umee/blob/main/x/uibc/README.md?plain=1#L27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- let's don't close a comment without updating the code or responding
- few other comments are still not resolved
- test is missing
- error check is missing
Description
We are allowing OUTFLOW IBC Transfers when either
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...