feat: simplify special asset pairs calculations

[toteki]

No description provided.

[codecov]

Codecov Report

Merging #2315 (7740d40) into main (7f05ad4) will decrease coverage by 5.11%.
Report is 294 commits behind head on main.
The diff coverage is 66.08%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2315      +/-   ##
==========================================
- Coverage   75.38%   70.28%   -5.11%     
==========================================
  Files         100      170      +70     
  Lines        8025    12659    +4634     
==========================================
+ Hits         6050     8897    +2847     
- Misses       1589     3158    +1569     
- Partials      386      604     +218     

Files	Coverage Δ
ante/ante.go	66.66% <100.00%> (+18.45%)	⬆️
ante/fee.go	80.00% <100.00%> (+1.64%)	⬆️
ante/spam_prevention.go	75.92% <ø> (ø)
app/inflation/inflation.go	100.00% <100.00%> (ø)
app/upgradev3/migrations.go	84.21% <ø> (+5.94%)	⬆️
util/coin/utoken.go	100.00% <100.00%> (ø)
util/ibc/ibc.go	58.82% <ø> (ø)
util/sdkutil/events.go	0.00% <ø> (ø)
util/store/store.go	52.06% <ø> (+10.65%)	⬆️
util/store/unmarshal.go	42.85% <ø> (ø)
... and 40 more

... and 103 files with indirect coverage changes

[toteki]

Seeing some wierd go mod errors on builds and tests - started appearing 3 commits ago at 497e5be

[robert-zaremba]

Could you point to the place where was the bug

[toteki]

Note: The original bug was in the logic for pairing normal assets durign max withdrawal, in which the position object was mutated by subtracting borrowed and collateral values from special asset pairs. The amount subtracted was too high, resulting in a negative coin amount.

This logic no longer exists in the refactor

[robert-zaremba]

approved