-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: inspect query warns on failing addresses #2341
Conversation
WalkthroughThe Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- swagger/swagger.yaml
- x/leverage/types/query.pb.go
Files selected for processing (2)
- proto/umee/leverage/v1/query.proto (1 hunks)
- x/leverage/keeper/inspector.go (3 hunks)
Files skipped from review due to trivial changes (1)
- proto/umee/leverage/v1/query.proto
Additional comments: 3
x/leverage/keeper/inspector.go (3)
29-35: The introduction of the
failures
slice and the conditional check for liquidator query enablement are correctly implemented.74-79: The logic to append failed addresses to the
failures
slice when an error occurs in getting the account position is correctly implemented.123-126: The
QueryInspectResponse
is correctly updated to include theFailures
field, which will return the list of failed addresses.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2341 +/- ##
==========================================
- Coverage 75.38% 70.16% -5.23%
==========================================
Files 100 170 +70
Lines 8025 12651 +4626
==========================================
+ Hits 6050 8877 +2827
- Misses 1589 3169 +1580
- Partials 386 605 +219
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- swagger/swagger.yaml
- x/leverage/types/query.pb.go
Files selected for processing (1)
- proto/umee/leverage/v1/query.proto (1 hunks)
Adds a helpful field for inspect query - will indicate if any addresses are being skipped due to price problems, for example.
Summary by CodeRabbit
New Features
inspect
query to include a list of accounts with uncalculated positions.Bug Fixes
Documentation