Consider module max withdraw in max_withdraw query #2462

deficruncher · 2024-03-17T11:11:14Z

Fix max_withdraw function so it considers MaxModuleWithdraw.

There are cases in which MaxModuleWithdraw is smaller than user MaxWithdraw. When it happens umee allows user to select invalid withdraw amount that will result in error when broadcasting transaction

Summary by CodeRabbit

Refactor
- Improved the calculation for maximum withdrawal amount for users, ensuring more accurate transaction limits.
- Updated the userMaxWithdraw method call to use q.Keeper.userMaxWithdraw for better functionality.
- Added logic to calculate the minimum value between uToken.Amount and moduleMaxWithdraw for enhanced processing.

coderabbitai · 2024-03-17T11:11:20Z

Walkthrough

The update involves refining the logic for calculating a user's maximum withdrawal amount in the grpc_query.go file. Specifically, it enhances the method call to access userMaxWithdraw directly via the Keeper and introduces a new step to determine the lesser of two values, uToken.Amount and moduleMaxWithdraw, as a preliminary action before moving forward with additional computations.

Changes

File	Summary
`.../grpc_query.go`	Updated `userMaxWithdraw` to `q.Keeper.userMaxWithdraw` and added logic for minimum value calculation.

🐰✨
To the code we hop and bound,
A tiny tweak, improvements found.
In the realm of withdraw and save,
We fine-tune the flow, the path we pave.
🌟 Between two sums, we pick the least,
Ensuring the code's beauty, not the beast.
Cheers to changes, small yet bright,
In the coder's world, they bring light. 🌈
🐰💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 0aeea63 and 52dfa1e.

Files selected for processing (1)

x/leverage/keeper/grpc_query.go (1 hunks)

x/leverage/keeper/grpc_query.go

…il int

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 52dfa1e and 8ec9cd3.

Files selected for processing (1)

x/leverage/keeper/grpc_query.go (1 hunks)

Files skipped from review as they are similar to previous changes (1)

x/leverage/keeper/grpc_query.go

robert-zaremba

LGTM. @toteki please check as well, this is related to the recent update you were doing as well.

codecov · 2024-03-18T20:00:37Z

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 68.91%. Comparing base (7f05ad4) to head (387b5f4).
Report is 408 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2462      +/-   ##
==========================================
- Coverage   75.38%   68.91%   -6.48%     
==========================================
  Files         100      184      +84     
  Lines        8025    10866    +2841     
==========================================
+ Hits         6050     7488    +1438     
- Misses       1589     2766    +1177     
- Partials      386      612     +226

Files	Coverage Δ
x/leverage/keeper/grpc_query.go	`64.33% <33.33%> (-2.88%)`	⬇️

... and 174 files with indirect coverage changes

robert-zaremba · 2024-03-18T20:18:19Z

there was a linter issue, I fixed it.

coderabbitai

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8ec9cd3 and 387b5f4.

Files selected for processing (1)

x/leverage/keeper/grpc_query.go (1 hunks)

x/leverage/keeper/grpc_query.go

deficruncher · 2024-03-19T05:51:42Z

Thx!

Additionally we might do the analogical change to MaxWithdraw message. I decided to only touch the query though, because its not consensus affecting.

Consider module max withdraw in max_withdraw query

52dfa1e

deficruncher requested a review from a team as a code owner March 17, 2024 11:11

coderabbitai bot reviewed Mar 17, 2024

View reviewed changes

x/leverage/keeper/grpc_query.go Outdated Show resolved Hide resolved

Restructure code, previously sdk.MinInt might have been called with n…

8ec9cd3

…il int

coderabbitai bot reviewed Mar 17, 2024

View reviewed changes

robert-zaremba reviewed Mar 18, 2024

View reviewed changes

fix lint issues

387b5f4

coderabbitai bot reviewed Mar 18, 2024

View reviewed changes

x/leverage/keeper/grpc_query.go Show resolved Hide resolved

robert-zaremba approved these changes Mar 18, 2024

View reviewed changes

robert-zaremba enabled auto-merge March 18, 2024 21:01

robert-zaremba disabled auto-merge March 18, 2024 21:01

robert-zaremba merged commit 32e7c21 into umee-network:main Mar 18, 2024
24 of 26 checks passed

toteki approved these changes Mar 18, 2024

View reviewed changes

coderabbitai bot mentioned this pull request Mar 26, 2024

fix(ugov amino): don't use proto.MessageName #2473

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consider module max withdraw in max_withdraw query #2462

Consider module max withdraw in max_withdraw query #2462

deficruncher commented Mar 17, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 17, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

coderabbitai bot left a comment

coderabbitai bot left a comment

robert-zaremba left a comment •

edited

Loading

codecov bot commented Mar 18, 2024 •

edited

Loading

robert-zaremba commented Mar 18, 2024

coderabbitai bot left a comment

deficruncher commented Mar 19, 2024

Consider module max withdraw in max_withdraw query #2462

Consider module max withdraw in max_withdraw query #2462

Conversation

deficruncher commented Mar 17, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Mar 17, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

robert-zaremba left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Mar 18, 2024 • edited Loading

Codecov Report

robert-zaremba commented Mar 18, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

deficruncher commented Mar 19, 2024

deficruncher commented Mar 17, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 17, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

robert-zaremba left a comment •

edited

Loading

codecov bot commented Mar 18, 2024 •

edited

Loading